Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(offline): Fix server certificate error when trying to store content #5848

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix(offline): Fix server certificate error when trying to store content #5848

merged 1 commit into from
Nov 2, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 2, 2023

Fixes #5132

@avelad avelad added type: bug Something isn't working correctly component: EME The issue involves the Encrypted Media Extensions web API priority: P1 Big impact or workaround impractical; resolve before feature release component: offline The issue involves the offline storage system of Shaka Player labels Nov 2, 2023
@avelad avelad added this to the v4.6 milestone Nov 2, 2023
@avelad avelad merged commit f4a35f2 into shaka-project:main Nov 2, 2023
19 of 21 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 2, 2023
Merged
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad deleted the storage-certificate branch November 2, 2023 17:49
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(offline): Fix server certificate error when trying to store conte…
b4d8e95 
…nt (shaka-project#5848)

Fixes shaka-project#5132
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 1, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: EME The issue involves the Encrypted Media Extensions web API component: offline The issue involves the offline storage system of Shaka Player priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

Shaka Error DRM.INVALID_SERVER_CERTIFICATE trying to store content when serverCertificateUri is set
3 participants
@avelad @shaka-bot @littlespex