Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TTML): Fix support of urls in smpte:backgroundImage #5851

Merged
merged 3 commits into from
Nov 6, 2023
Merged

fix(TTML): Fix support of urls in smpte:backgroundImage #5851

merged 3 commits into from
Nov 6, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 3, 2023

Fixes #5049

@avelad avelad added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Nov 3, 2023
@avelad avelad added this to the v4.6 milestone Nov 3, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

theodab
theodab requested changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the name of this PR is inaccurate.
I'm not an expert on TTML or anything, but looking at the code we already do support smpte:backgroundImage. We just support a different use-case of it than the one this PR adds, right?

lib/text/text_engine.js Outdated Show resolved Hide resolved
@avelad avelad changed the title fix(TTML): Display subtitles from TTML with smpte:backgroundImage fix(TTML): Fix support of urls in smpte:backgroundImage Nov 6, 2023
@avelad avelad requested a review from theodab November 6, 2023 08:08
@avelad avelad merged commit fa93d53 into shaka-project:main Nov 6, 2023
14 of 15 checks passed
@avelad avelad deleted the ttml-smpte-backgroundImage branch November 6, 2023 10:27
@shaka-bot shaka-bot mentioned this pull request Nov 6, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(TTML): Fix support of urls in smpte:backgroundImage (shaka-projec…
41d79de 
…t#5851)

Fixes shaka-project#5049
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 5, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

Shaka Player does not display subtitles from TTML with smpte:backgroundImage
3 participants
@avelad @shaka-bot @theodab