Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow get seekRange on manifestparsed event in some cases #5892

Merged
merged 1 commit into from Nov 16, 2023
Merged

fix: Allow get seekRange on manifestparsed event in some cases #5892

merged 1 commit into from Nov 16, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 15, 2023

Fixes #5115

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Nov 15, 2023
@avelad avelad added this to the v4.6 milestone Nov 15, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 90.00%

@avelad avelad merged commit 606d693 into shaka-project:main Nov 16, 2023
18 of 20 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 16, 2023
Merged
@avelad avelad deleted the manifestparsed-seek-range branch November 16, 2023 08:59
@Wayne-Morgan
Copy link
Contributor

Thanks.

Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix: Allow get seekRange on manifestparsed event in some cases (shaka…
678e2b0 
…-project#5892)

Fixes shaka-project#5115
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 15, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

Can't find seekRange early enough to use it for updateStartTime
4 participants
@avelad @shaka-bot @Wayne-Morgan @theodab