Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Common Media Server Data (CMSD) #5900

Merged
merged 2 commits into from Nov 20, 2023
Merged

feat: Add support for Common Media Server Data (CMSD) #5900

merged 2 commits into from Nov 20, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 16, 2023

Closes #5890

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Nov 16, 2023
@avelad avelad added this to the v5.0 milestone Nov 16, 2023
@avelad avelad marked this pull request as draft November 16, 2023 11:47
@shaka-bot
Copy link
Collaborator

shaka-bot commented Nov 16, 2023 •
edited

Incremental code coverage: 93.43%

@avelad avelad marked this pull request as ready for review November 20, 2023 07:57
theodab
theodab requested changes Nov 20, 2023
View reviewed changes
externs/shaka/player.js Show resolved Hide resolved
externs/shaka/player.js Show resolved Hide resolved
externs/shaka/player.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab November 20, 2023 08:21
@avelad avelad merged commit 966b910 into shaka-project:main Nov 20, 2023
15 of 16 checks passed
@avelad avelad deleted the cmsd branch November 20, 2023 13:07
@shaka-bot shaka-bot mentioned this pull request Nov 20, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
feat: Add support for Common Media Server Data (CMSD) (shaka-project#…
61d2d56 
…5900)

Closes shaka-project#5890
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 19, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

Add feature support for Common Media Server Data
3 participants
@avelad @shaka-bot @theodab