Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Fix false redirect detection #5910

Merged
merged 1 commit into from Nov 21, 2023
Merged

fix(DASH): Fix false redirect detection #5910

merged 1 commit into from Nov 21, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 20, 2023

Fixes #2216

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format labels Nov 20, 2023
@avelad avelad added this to the v5.0 milestone Nov 20, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 3a68623 into shaka-project:main Nov 21, 2023
17 of 21 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 20, 2023
Merged
@avelad avelad deleted the false-redirect-dash branch November 21, 2023 13:31
avelad added a commit that referenced this pull request Nov 22, 2023
@avelad
fix(DASH): Fix false redirect detection (#5910)
eca7bfb 
Fixes #2216
@shaka-bot shaka-bot mentioned this pull request Nov 22, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(DASH): Fix false redirect detection (shaka-project#5910)
2a090fc 
Fixes shaka-project#2216
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 20, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

False redirect detection in dash parser
3 participants
@avelad @shaka-bot @theodab