Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DASH): Add support for location in Content Steering #5914

Merged
merged 3 commits into from Nov 22, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 21, 2023

According to https://github.com/Dash-Industry-Forum/Dash-Industry-Forum.github.io/files/11722876/DASH-IF-CTS-001-1.0.0.pdf, Location elements can have serviceLocation, so we need support it.

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: DASH The issue involves the MPEG DASH manifest format labels Nov 21, 2023
@avelad avelad changed the title feat(DASH): Add support for location Content Steering feat(DASH): Add support for location in Content Steering Nov 21, 2023
@shaka-bot
Copy link
Collaborator

shaka-bot commented Nov 21, 2023

Incremental code coverage: 98.08%

lib/dash/dash_parser.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab November 22, 2023 15:19
@avelad avelad merged commit 8f453c2 into shaka-project:main Nov 22, 2023
12 of 16 checks passed
@avelad avelad deleted the dash-location-content-steering branch November 23, 2023 07:41
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 21, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants