Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Recognize CEA subtitles when CLOSED-CAPTIONS attribute is missing #5916

Merged
merged 1 commit into from Nov 22, 2023
Merged

fix(HLS): Recognize CEA subtitles when CLOSED-CAPTIONS attribute is missing #5916

merged 1 commit into from Nov 22, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 22, 2023

Fixes #5915

@avelad avelad requested a review from theodab November 22, 2023 07:58
@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 22, 2023
@avelad avelad added this to the v5.0 milestone Nov 22, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 58d4597 into shaka-project:main Nov 22, 2023
15 of 20 checks passed
@avelad avelad deleted the hls-cea branch November 22, 2023 08:57
@shaka-bot shaka-bot mentioned this pull request Nov 21, 2023
Merged
avelad added a commit that referenced this pull request Nov 22, 2023
@avelad
fix(HLS): Recognize CEA subtitles when CLOSED-CAPTIONS attribute is m…
8560842 
…issing (#5916)

Fixes #5915
@shaka-bot shaka-bot mentioned this pull request Nov 22, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(HLS): Recognize CEA subtitles when CLOSED-CAPTIONS attribute is m…
4b93f3b 
…issing (shaka-project#5916)

Fixes shaka-project#5915
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 21, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

The CEA subtitles can not be recognised with latest version (4.6.0)
3 participants
@avelad @shaka-bot @theodab