fix(HLS): Fix variant synchronization in HLS after selectVariantTrack #5984
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
theodab
approved these changes
Dec 5, 2023
avelad
added a commit
that referenced
this pull request
Dec 5, 2023
avelad
added a commit
that referenced
this pull request
Dec 5, 2023
|
Hi. This magic number has been touched upon in changes quite recently. Will returning a smaller value cause problems? From what I understand in the code, the adaptation variable needs to be true until segment from new variant not appended with appendBuffer. Currently this variable can be reset after appendBuffer for the currently selected variant |
|
Yes, I had other streams who have the same problem. This change is safe. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5849