Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Fix disable PiP when using documentPictureInPicture #5992

Merged
merged 1 commit into from Dec 5, 2023
Merged

fix(UI): Fix disable PiP when using documentPictureInPicture #5992

merged 1 commit into from Dec 5, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Dec 5, 2023

Fixes #5991

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release labels Dec 5, 2023
@avelad avelad added this to the v5.0 milestone Dec 5, 2023
@avelad avelad mentioned this pull request Dec 5, 2023
Closed
@avelad avelad merged commit 6229284 into shaka-project:main Dec 5, 2023
18 of 21 checks passed
@shaka-bot shaka-bot mentioned this pull request Dec 5, 2023
Merged
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad deleted the disable-pip branch January 8, 2024 08:36
avelad added a commit that referenced this pull request Jan 8, 2024
@avelad
fix(UI): Fix disable PiP when using documentPictureInPicture (#5992)
74b0ad4 
Fixes #5991
@shaka-bot shaka-bot mentioned this pull request Jan 8, 2024
Merged
avelad added a commit that referenced this pull request Jan 8, 2024
@avelad
fix(UI): Fix disable PiP when using documentPictureInPicture (#5992)
521bbe2 
Fixes #5991
@shaka-bot shaka-bot mentioned this pull request Jan 8, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Feb 3, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

How to disable PictureInPicture in shaka player
3 participants
@avelad @shaka-bot @theodab