perf(transmuxer): various performance improvements #6003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
reviewed
Dec 7, 2023
avelad
added
type: performance
vanyaxk
force-pushed
the
perf/improve-performance-transmuxer
branch
from
6dfebf3
to
8bedbb9
Compare
|
Incremental code coverage: 81.25% |
vanyaxk
force-pushed
the
perf/improve-performance-transmuxer
branch
from
8bedbb9
to
a3b90a0
Compare
avelad
approved these changes
Jan 8, 2024
avelad
added a commit
that referenced
this pull request
Jan 8, 2024
This change improves loop performance - creating new arrays is not performant in large loops, and a traditional for loop is more performant than for .. of for large concatenations --------- Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar> Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
avelad
added a commit
that referenced
this pull request
Jan 8, 2024
This change improves loop performance - creating new arrays is not performant in large loops, and a traditional for loop is more performant than for .. of for large concatenations --------- Co-authored-by: Ivan Kohut <ivan.kohut@lamin.ar> Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves loop performance - creating new arrays is not performant in large loops, and a traditional for loop is more performant than for .. of for large concatenations