Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(mp4generator): stop nesting concat in methods #6041

Merged
merged 1 commit into from Jan 8, 2024
Merged

perf(mp4generator): stop nesting concat in methods #6041

merged 1 commit into from Jan 8, 2024

Conversation

vanyaxk
Copy link
Contributor

@vanyaxk vanyaxk commented Jan 8, 2024

This change removes concat util function from mp4 generator iterations and runs it later, as well as stops creating new Uint8 arrays, as concat does this within itself.

@avelad avelad changed the title refactor(mp4generator): stop nesting concat in methods perf(mp4generator): stop nesting concat in methods Jan 8, 2024
@avelad avelad added component: HLS The issue involves Apple's HLS manifest format type: performance A performance issue priority: P1 Big impact or workaround impractical; resolve before feature release labels Jan 8, 2024
@avelad avelad added this to the v5.0 milestone Jan 8, 2024
@avelad avelad merged commit f52dd2b into shaka-project:main Jan 8, 2024
15 of 19 checks passed
@shaka-bot shaka-bot mentioned this pull request Jan 8, 2024
Merged
avelad pushed a commit that referenced this pull request Jan 8, 2024
@vanyaxk @avelad
perf(mp4generator): stop nesting concat in methods (#6041)
f007f8f 
This change removes `concat` util function from mp4 generator iterations
and runs it later, as well as stops creating new Uint8 arrays, as
`concat` does this within itself.
@shaka-bot shaka-bot mentioned this pull request Jan 8, 2024
Merged
avelad pushed a commit that referenced this pull request Jan 8, 2024
@vanyaxk @avelad
perf(mp4generator): stop nesting concat in methods (#6041)
2bc303b 
This change removes `concat` util function from mp4 generator iterations
and runs it later, as well as stops creating new Uint8 arrays, as
`concat` does this within itself.
@shaka-bot shaka-bot mentioned this pull request Jan 8, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 8, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: performance A performance issue
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vanyaxk @avelad @shaka-bot