Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Live recovery after disconnects #6048

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix(HLS): Live recovery after disconnects #6048

merged 2 commits into from
Jan 9, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jan 8, 2024

Fixes #6019

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Jan 8, 2024
@avelad avelad added this to the v5.0 milestone Jan 8, 2024
@avelad avelad requested a review from theodab January 8, 2024 14:23
theodab
theodab requested changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise.

lib/hls/hls_parser.js Show resolved Hide resolved
@avelad avelad requested a review from theodab January 9, 2024 08:40
@avelad avelad merged commit 8476631 into shaka-project:main Jan 9, 2024
12 of 16 checks passed
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
@avelad avelad deleted the hls-live-recovery branch January 9, 2024 08:43
avelad added a commit that referenced this pull request Jan 9, 2024
@avelad
fix(HLS): Live recovery after disconnects (#6048)
44fdb64 
Fixes #6019
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
avelad added a commit that referenced this pull request Jan 9, 2024
@avelad
fix(HLS): Live recovery after disconnects (#6048)
0a5d42b 
Fixes #6019
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Feb 17, 2024
@avelad @joeyparrish
fix(HLS): Live recovery after disconnects (#6048)
468425a 
Fixes #6019
@shaka-bot shaka-bot mentioned this pull request Feb 17, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

Live HLS manifest and disconnects
3 participants
@avelad @theodab @shaka-bot