Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): Separate trackLabelFormat settings for text tracks and audio tracks #6052

Merged
merged 1 commit into from Jan 9, 2024
Merged

feat(UI): Separate trackLabelFormat settings for text tracks and audio tracks #6052

merged 1 commit into from Jan 9, 2024
+15 −3

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jan 8, 2024

Closes #6008

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Jan 8, 2024
@avelad avelad added this to the v5.0 milestone Jan 8, 2024
@avelad avelad requested a review from theodab January 8, 2024 15:34
@avelad avelad merged commit a94a602 into shaka-project:main Jan 9, 2024
15 of 19 checks passed
@avelad avelad deleted the textTrackLabelFormat branch January 9, 2024 08:39
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

UI: Separate trackLabelFormat settings for text tracks and audio tracks
3 participants
@avelad @theodab @shaka-bot