Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text roles being combined incorrectly in some multiperiod cases #6055

Merged
merged 1 commit into from Jan 9, 2024
Merged

fix: text roles being combined incorrectly in some multiperiod cases #6055

merged 1 commit into from Jan 9, 2024

Conversation

littlespex
Copy link
Collaborator

Resolves #6054

@avelad avelad merged commit b463e39 into shaka-project:main Jan 9, 2024
14 of 18 checks passed
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
avelad pushed a commit that referenced this pull request Jan 9, 2024
@littlespex @avelad
fix: text roles being combined incorrectly in some multiperiod cases (#…
f32a769 
…6055)

Resolves #6054
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
avelad pushed a commit that referenced this pull request Jan 9, 2024
@littlespex @avelad
fix: text roles being combined incorrectly in some multiperiod cases (#…
ee42570 
…6055)

Resolves #6054
@shaka-bot shaka-bot mentioned this pull request Jan 9, 2024
Merged
joeyparrish pushed a commit that referenced this pull request Feb 17, 2024
@littlespex @joeyparrish
fix: text roles being combined incorrectly in some multiperiod cases (#…
f6fea75 
…6055)

Resolves #6054

Backported to v4.3.x
@shaka-bot shaka-bot mentioned this pull request Feb 17, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

@agajassi agajassi agajassi approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text track roles are being incorrectly combined in certain multi-period cases
4 participants
@littlespex @avelad @agajassi @shaka-bot