feat!: Remove DOM Parser #6063
Merged
feat!: Remove DOM Parser #6063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use xml parser fixed getContents bug fix NS sorting out typing... half way I hope fix more typings move type fix some more tests tests fixed
remove ttml and vtt parser changes for now.. remove ttml and vtt parser changes for now.. remove ttml and vtt parser changes for now..
|
@dave-nicholas Since it change the returns of some externs, i'll change it to feat! |
avelad
added
type: enhancement
absidue
reviewed
Jan 9, 2024
avelad
requested changes
Jan 12, 2024
dave-nicholas
force-pushed
the
txml-dash-mss
branch
2 times, most recently
from
1214aa4
to
dcaa3e3
Compare
remove unecessary space.. remove unecessary space.. remove unecessary space..
dave-nicholas
force-pushed
the
txml-dash-mss
branch
from
dcaa3e3
to
81c83de
Compare
avelad
requested changes
Jan 16, 2024
avelad
approved these changes
Jan 16, 2024
avelad
added
component: TTML
theodab
requested changes
Jan 19, 2024
|
@theodab can you review it again? Thanks! |
theodab
approved these changes
Jan 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
The native DOM Parser can perform poorly on some older devices, this approach is faster on newer devices but is considerably better on older devices.
This PR replaces the usage of the DOM Parser for DASH, MSS, VTT and TTML.
The draw back of this approach that it does not include any validation at the cost of better performance.
BEGIN_COMMIT_OVERRIDE
feat: Replace native DOM Parser with a more performant one (#6063)
END_COMMIT_OVERRIDE