Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix handling of multiple CC tracks #6076

Merged
merged 1 commit into from Jan 10, 2024

Conversation

tykus160
Copy link
Contributor

Due to issue around channel calculation, shaka was never using CC4 track and data from there were landing in CC2 track.

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Jan 10, 2024
@avelad avelad added this to the v5.0 milestone Jan 10, 2024
@avelad avelad self-requested a review January 10, 2024 14:17
@avelad avelad merged commit 44cb8a2 into shaka-project:main Jan 10, 2024
15 of 19 checks passed
@tykus160 tykus160 deleted the wt-cea-fix-upstream branch January 10, 2024 15:22
avelad pushed a commit that referenced this pull request Jan 11, 2024
Due to issue around channel calculation, shaka was never using CC4 track
and data from there were landing in CC2 track.
avelad pushed a commit that referenced this pull request Jan 11, 2024
Due to issue around channel calculation, shaka was never using CC4 track
and data from there were landing in CC2 track.
joeyparrish pushed a commit that referenced this pull request Feb 17, 2024
Due to issue around channel calculation, shaka was never using CC4 track
and data from there were landing in CC2 track.

Backported to v4.3.x
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants