feat(DASH): Allow PeriodCombiner for using streams once #6097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
reviewed
Jan 12, 2024
avelad
reviewed
Jan 12, 2024
| * only once in period flattening. It speeds up underlying algorithm | ||
| * but may raise issues if manifest does not have stream consistency | ||
| * between periods. | ||
| * Defaults to <code>false</code>. |
There was a problem hiding this comment.
For me this should default to true, @littlespex , what do you think?
There was a problem hiding this comment.
I'd be more than happy to set it to true by default, but potentially it will increase number of PERIOD_FLATTENING_FAILED errors on not well structured manifests. We'd have to add mention of this setting in error description or in FAQ (or both).
There was a problem hiding this comment.
Defaulting to true would technically be a breaking change for us. You would have call out in the release notes that if you must opt-out if you want consistent behavior with previous versions after upgrading.
avelad
added
type: enhancement
avelad
approved these changes
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our streams we have guarantee that every track will have a single match in every period. This change allows
PeriodCombinerto take benefit of this knowledge.I was testing
PeriodCombiner.combinePeriods()performance of mentioned changes on Tizen 2021 on 2 streams and I've got following results:Both streams are VOD.
Stream 1 has 18 periods with 6 video & audio tracks in each.
Stream 2 has 18 periods with 6 video tracks & 36 audio tracks in each.