fix: Change quality only when adding the last partial segment and it is fast switching #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
force-pushed
the
fastswitching-fix
branch
from
6b6e6ed
to
7bd4e71
Compare
…is fast switching
avelad
force-pushed
the
fastswitching-fix
branch
from
7bd4e71
to
b6542a7
Compare
theodab
requested changes
Jan 18, 2024
externs/shaka/abr_manager.js
Outdated
| * | ||
| * @exportDoc | ||
| */ | ||
| allowSuggestStreams() {} |
There was a problem hiding this comment.
Overall, I think the design of this PR looks fine, but I don't like the name of this method.
allowSuggestStreams sounds to me like it's setting a configuration value, like it will make the abr manager start suggesting streams from now on.
To better convey that this will trigger at most one stream suggestion, I'd go for a name more like trySuggestStreams.
theodab
approved these changes
Jan 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.