fix: Reject Opus encrypted on Firefox Android #6115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
tykus160
reviewed
Jan 17, 2024
tykus160
approved these changes
Jan 17, 2024
theodab
approved these changes
Jan 18, 2024
| @@ -426,6 +429,13 @@ shaka.util.StreamUtils = class { | |||
|
|
|||
| const audio = variant.audio; | |||
|
|
|||
| if (isFirefoxAndroid && audio && audio.encrypted && | |||
There was a problem hiding this comment.
I would add a comment explaining why we are filtering this. Maybe referencing #6111?
avelad
added a commit
that referenced
this pull request
Jan 18, 2024
avelad
added a commit
that referenced
this pull request
Jan 18, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Feb 17, 2024
Fixes #6111 Backported to v4.3.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6111