Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Avoid duplicate AES request when using the same info #6118

Merged
merged 2 commits into from Jan 17, 2024
Merged

fix(HLS): Avoid duplicate AES request when using the same info #6118

merged 2 commits into from Jan 17, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jan 17, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Jan 17, 2024
@avelad avelad added this to the v5.0 milestone Jan 17, 2024
littlespex
littlespex reviewed Jan 17, 2024
View reviewed changes
lib/hls/hls_parser.js Outdated Show resolved Hide resolved
@avelad avelad merged commit 1671a3e into shaka-project:main Jan 17, 2024
12 of 16 checks passed
@shaka-bot shaka-bot mentioned this pull request Jan 17, 2024
Merged
@avelad avelad deleted the hls-aes-cache branch January 18, 2024 06:57
joeyparrish pushed a commit that referenced this pull request Feb 17, 2024
@avelad @joeyparrish
fix(HLS): Avoid duplicate AES request when using the same info (#6118)
a1084f5 
Backported to v4.3.x
@shaka-bot shaka-bot mentioned this pull request Feb 17, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 17, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@littlespex littlespex littlespex approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avelad @littlespex @shaka-bot