Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing properties to PlayButton type #6130

Merged

Conversation

Reeska
Copy link
Contributor

@Reeska Reeska commented Jan 19, 2024

Fixes #6125.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Jan 22, 2024
@avelad avelad added this to the v5.0 milestone Jan 22, 2024
@avelad avelad merged commit 8f0db8e into shaka-project:main Jan 22, 2024
14 of 18 checks passed
@Reeska
Copy link
Contributor Author

Reeska commented Jan 22, 2024

Thanks you @avelad for the approval !

avelad pushed a commit that referenced this pull request Jan 24, 2024
avelad pushed a commit that referenced this pull request Jan 24, 2024
joeyparrish pushed a commit that referenced this pull request Feb 17, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 22, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing properties in generated PlayButton TypeScript class
3 participants