Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WebVTT): Remove un-needed VTT payload normalisation #6145

Merged

Conversation

dave-nicholas
Copy link
Contributor

The tXml parser gracefully handles this now, so it is no longer needed.

@avelad avelad changed the title fix: remove un-needed VTT payload normalisation feat(WebVTT): Remove un-needed VTT payload normalisation Jan 23, 2024
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: WebVTT The issue involves WebVTT subtitles specifically labels Jan 23, 2024
@avelad
Copy link
Collaborator

avelad commented Jan 23, 2024

@dave-nicholas I convert it into a feat so that it is not included until 5.0 is released since it depends on changes in this release.

@avelad avelad added this to the v5.0 milestone Jan 23, 2024
@avelad avelad merged commit ee600c4 into shaka-project:main Jan 23, 2024
15 of 19 checks passed
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 23, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants