Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Fix initial ads configuration #6176

Merged
merged 1 commit into from Jan 29, 2024
Merged

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jan 29, 2024

Related to #6169

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release labels Jan 29, 2024
@avelad avelad added this to the v5.0 milestone Jan 29, 2024
@avelad avelad merged commit 5b141eb into shaka-project:main Jan 29, 2024
16 of 20 checks passed
avelad added a commit that referenced this pull request Jan 30, 2024
avelad added a commit that referenced this pull request Jan 30, 2024
@avelad avelad deleted the ads-config branch January 30, 2024 08:54
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 29, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants