Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detect maximum HW resolution automatically on some platforms #6180

Merged
merged 4 commits into from
Feb 1, 2024
Merged

feat: Detect maximum HW resolution automatically on some platforms #6180

merged 4 commits into from
Feb 1, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jan 29, 2024

No description provided.

@avelad avelad added type: enhancement New feature or request platform: TV/STB Issues affecting smart TV or set-top box platforms priority: P3 Useful but not urgent platform: Cast Issues affecting Cast devices platform: WebOS Issues affecting WebOS platform: Tizen Issues affecting Tizen labels Jan 29, 2024
@avelad avelad added this to the v5.0 milestone Jan 29, 2024
@avelad avelad force-pushed the detect-max-hw-resolution branch 3 times, most recently from bee79e2 to 089aaf1 Compare January 29, 2024 16:48
@avelad avelad marked this pull request as draft January 30, 2024 07:47
tykus160
tykus160 reviewed Jan 30, 2024
View reviewed changes
lib/player.js Outdated Show resolved Hide resolved
@avelad avelad added platform: Playstation 4 Issues affecting Playstation 4 platform: Playstation 5 Issues affecting Playstation 5 labels Jan 30, 2024
@avelad avelad marked this pull request as ready for review January 30, 2024 08:55
@avelad avelad requested a review from tykus160 January 30, 2024 08:55
tykus160
tykus160 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with PlayStation, but on other platforms it looks OK!

lib/util/platform.js Outdated Show resolved Hide resolved
theodab
theodab requested changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

lib/util/stream_utils.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab February 1, 2024 08:30
@avelad avelad merged commit 278c7bc into shaka-project:main Feb 1, 2024
12 of 15 checks passed
@shaka-bot shaka-bot mentioned this pull request Feb 1, 2024
Merged
@avelad avelad deleted the detect-max-hw-resolution branch February 2, 2024 07:53
Vasanthavanan-Devarajan pushed a commit to Vasanthavanan-Devarajan/shaka-player that referenced this pull request Feb 20, 2024
@avelad @Vasanthavanan-Devarajan
feat: Detect maximum HW resolution automatically on some platforms (s…
f7887c9 
…haka-project#6180)
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 1, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@tykus160 tykus160 tykus160 approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
platform: Cast Issues affecting Cast devices platform: Playstation 4 Issues affecting Playstation 4 platform: Playstation 5 Issues affecting Playstation 5 platform: Tizen Issues affecting Tizen platform: TV/STB Issues affecting smart TV or set-top box platforms platform: WebOS Issues affecting WebOS priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avelad @theodab @tykus160 @shaka-bot