Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include app specific data in licenseRequest body. #62

Closed
sanbornhilland opened this issue Apr 21, 2015 · 4 comments
Closed

Include app specific data in licenseRequest body. #62

sanbornhilland opened this issue Apr 21, 2015 · 4 comments
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@sanbornhilland
Copy link
Contributor

We're thinking about whether it makes sense to include additional data in the licenseRequest for authentication purposes. Is there a straightforward way to do this at the moment? It looks to me like only the URL and initData can be provided from outside Shaka, but not additional request body attributes separate from custom initData. @joeyparrish do you guys have opinions about this?

@joeyparrish joeyparrish added the type: enhancement New feature or request label Apr 21, 2015
@joeyparrish joeyparrish self-assigned this Apr 21, 2015
@joeyparrish
Copy link
Member

I was thinking of adding hooks similar to the license response post-processor. It would be something like a license request pre-processor, to allow you to alter/wrap the request before it is sent to the server.

Would it suffice to modify the request body, or are you looking to control other things as well? All I can think of is the URL, the body, the request headers, and whether or not to send cookies.

The URL has already been set by the application in DrmSchemeInfo, but is there a need to modify it later with data that wasn't available at the time ContentProtection was interpreted?

@sanbornhilland
Copy link
Contributor Author

No, I think what you have in mind is essentially what I have in mind as well. Specifically the option to add additional data into the request body other than the initData would be great (headers and cookies I anticipate would also be useful), otherwise we would have to add params to the url that we provide to DrmSchemeInfo and that's not ideal.

@somerobmitchell
Copy link

Hi Guys,

My company would like to see this as well. We have extra information we need to send to the license server in the body of the request.

Having a hook similar to the post-processor would be ideal and we would only need to alter the body, the content type of the body (we use json not an array buffer) and the headers.

In our workflow it would not be necessary to alter the url after the content protection has been interpreted.

@joeyparrish
Copy link
Member

Okay, then we'll see about providing access to body, headers, and content type. Thanks for the input!

@joeyparrish joeyparrish removed their assignment Apr 24, 2015
@joeyparrish joeyparrish added this to the v1.4.0 milestone Apr 28, 2015
@tdrews tdrews self-assigned this Jun 2, 2015
@tdrews tdrews closed this as completed in 6d08f0b Jun 9, 2015
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants