fix: don't double wrap URIs for HLS key requests #6246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
constructSegmentUris
util already returns an array, so the call tomakeRequest
was being made with an array of arrays. This wasn't causing errors for requests that use thefetch
plugin, sincefetch
will stringify the first argument if it's an array. But the data URI plugin expects to receive a string and calls.split()
on it, so keys using data URIs throw an error if the URI is wrapped in an array.Thanks to #6243 and @andrew0