Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add includeKeys to CMCD config to allow filtering of CMCD data #6248

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

littlespex
Copy link
Collaborator

@littlespex littlespex commented Feb 15, 2024

This PR adds the ability to filter/limit the amount of data transmitted when CMCD is enabled. It matches the functionality provided in dash.js and hls.js and addresses concernes raised by video providers:

cta-wave/common-media-client-data#122

Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small nits to pick. I seem to recall that approvals are sticky, so you can merge after those are corrected.

externs/shaka/player.js Outdated Show resolved Hide resolved
lib/util/cmcd_manager.js Outdated Show resolved Hide resolved
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@littlespex littlespex merged commit 5a025fb into shaka-project:main Feb 15, 2024
13 of 16 checks passed
@littlespex littlespex deleted the task/cmcd-include-keys branch February 15, 2024 21:54
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants