Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(text): Add time context to modifyCueCallback #6252

Merged
merged 1 commit into from Feb 20, 2024
Merged

feat(text): Add time context to modifyCueCallback #6252

merged 1 commit into from Feb 20, 2024

Conversation

theodab
Copy link
Collaborator

@theodab theodab commented Feb 17, 2024

No description provided.

@theodab theodab added type: enhancement New feature or request component: captions/subtitles The issue involves captions or subtitles labels Feb 17, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@theodab theodab merged commit 03633e4 into shaka-project:main Feb 20, 2024
15 of 18 checks passed
@theodab theodab deleted the modifyCueCallbackBranch branch February 20, 2024 08:37
@shaka-bot shaka-bot mentioned this pull request Feb 20, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 20, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees

@joeyparrish joeyparrish

Labels
component: captions/subtitles The issue involves captions or subtitles status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theodab @shaka-bot @joeyparrish