Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): Fix bad init segment request with byterange when using media playlist #6297

Merged
merged 1 commit into from Feb 26, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Feb 26, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Feb 26, 2024
@avelad avelad added this to the v5.0 milestone Feb 26, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@joeyparrish
Copy link
Member

@avelad, would a new test make sense?

@avelad
Copy link
Collaborator Author

avelad commented Feb 26, 2024

@joeyparrish I plan to make an improved testsuite for media playlist, but it will have to be when I return (in 4 weeks).

@avelad avelad merged commit 6a8f972 into shaka-project:main Feb 26, 2024
21 checks passed
@avelad avelad deleted the fix-hls-get-init-segment branch February 26, 2024 22:44
joeyparrish pushed a commit that referenced this pull request Feb 26, 2024
joeyparrish pushed a commit that referenced this pull request Feb 26, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 26, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants