Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: getPlayheadTimeAsDate() differs from X-EXT-PROGRAM-DATE-TIME #6330

Merged
merged 1 commit into from Mar 6, 2024

Conversation

theodab
Copy link
Collaborator

@theodab theodab commented Mar 6, 2024

This reverts 776b69d

Closes #6317
Closes #6299
Reopening issue #5939

BEGIN_COMMIT_OVERRIDE
fix: Fix HLS segment index errors and x-program-date-time errors since v4.7.4

Closes #6317
Closes #6299
Reopening issue #5939
END_COMMIT_OVERRIDE

@theodab theodab added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format labels Mar 6, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad
Copy link
Collaborator

avelad commented Mar 6, 2024

You need reopen the associated issue

@joeyparrish
Copy link
Member

I reopened #5939 with a comment.

@joeyparrish joeyparrish merged commit fd6b3d0 into shaka-project:main Mar 6, 2024
20 checks passed
@theodab theodab deleted the revert5939branch branch March 6, 2024 22:14
avelad pushed a commit that referenced this pull request Apr 8, 2024
avelad pushed a commit that referenced this pull request Apr 8, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 5, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
4 participants