Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transmuxer): Support raw AAC with TS extension #6360

Merged
merged 7 commits into from Apr 1, 2024
Merged

fix(transmuxer): Support raw AAC with TS extension #6360

merged 7 commits into from Apr 1, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Mar 25, 2024 •
edited

Fixes #6322
Fixes #6357

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: transmuxer The issue involves our built-in transmuxer labels Mar 25, 2024
@avelad avelad added this to the v5.0 milestone Mar 25, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Mar 25, 2024 •
edited

Incremental code coverage: 77.78%

@avelad avelad mentioned this pull request Mar 25, 2024
Closed
joeyparrish
joeyparrish requested changes Mar 25, 2024
View reviewed changes
lib/transmuxer/ts_transmuxer.js Outdated Show resolved Hide resolved
lib/transmuxer/ts_transmuxer.js Outdated Show resolved Hide resolved
lib/transmuxer/ts_transmuxer.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish March 26, 2024 14:25
@avelad
Copy link
Collaborator Author

avelad commented Mar 27, 2024

@joeyparrish I implemented another solution, I hope this new solution is more to your liking

@avelad avelad requested a review from joeyparrish March 27, 2024 08:15
joeyparrish
joeyparrish approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am concerned that the new test case failed in all three test runs on Tizen, though. Can you take a look?

@avelad
Copy link
Collaborator Author

avelad commented Apr 1, 2024

Looks good to me. I am concerned that the new test case failed in all three test runs on Tizen, though. Can you take a look?

Now all test are green!

@avelad avelad merged commit 7c6e846 into shaka-project:main Apr 1, 2024
30 checks passed
@shaka-bot shaka-bot mentioned this pull request Apr 1, 2024
Merged
@avelad avelad deleted the aac-raw-ts-extension branch April 1, 2024 07:28
@0x24D 0x24D mentioned this pull request Apr 2, 2024
Closed
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
fix(transmuxer): Support raw AAC with TS extension (#6360)
3cf68c1 
Fixes #6322
Fixes #6357
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
fix(transmuxer): Support raw AAC with TS extension (#6360)
e5296c2 
Fixes #6322
Fixes #6357
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: transmuxer The issue involves our built-in transmuxer priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
4 participants
@avelad @shaka-bot @joeyparrish @theodab