Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebVTT): Fix multiline colored VTT subtitles #6394

Merged
merged 1 commit into from Apr 4, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 3, 2024

Fixes #6374

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Apr 3, 2024
@avelad avelad added this to the v5.0 milestone Apr 3, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 25427c7 into shaka-project:main Apr 4, 2024
21 of 22 checks passed
@avelad avelad deleted the multiline-colored-vtt branch April 4, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiline colored VTT subtitles displayed on one line
3 participants