Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TTML): Fix trim surrounding spaces with xml:space="default" #6395

Merged
merged 1 commit into from Apr 4, 2024
Merged

fix(TTML): Fix trim surrounding spaces with xml:space="default" #6395

merged 1 commit into from Apr 4, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 3, 2024

Fixes #4974

@avelad avelad added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround labels Apr 3, 2024
@avelad avelad added this to the v5.0 milestone Apr 3, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit bcedec3 into shaka-project:main Apr 4, 2024
20 checks passed
@avelad avelad deleted the ttml-surrounding-spaces branch April 4, 2024 08:46
@shaka-bot shaka-bot mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: TTML The issue involves TTML subtitles specifically priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

Surrounding spaces are trimmed from TTML inline text spans
3 participants
@avelad @shaka-bot @theodab