Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Set delay to 0 for LL streams #6406

Merged
merged 2 commits into from
Apr 5, 2024
Merged

fix(DASH): Set delay to 0 for LL streams #6406

merged 2 commits into from
Apr 5, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 4, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Apr 4, 2024
@avelad avelad added this to the v5.0 milestone Apr 4, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

theodab
theodab requested changes Apr 5, 2024
View reviewed changes
lib/dash/dash_parser.js Show resolved Hide resolved
theodab
theodab requested changes Apr 5, 2024
View reviewed changes
lib/dash/dash_parser.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab April 5, 2024 06:54
@avelad avelad merged commit b7b2fc9 into shaka-project:main Apr 5, 2024
15 of 16 checks passed
@avelad avelad deleted the dash-ll branch April 5, 2024 10:08
@shaka-bot shaka-bot mentioned this pull request Apr 5, 2024
Merged
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
fix(DASH): Set delay to 0 for LL streams (#6406)
1ccf611
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
avelad added a commit that referenced this pull request Apr 8, 2024
@avelad
fix(DASH): Set delay to 0 for LL streams (#6406)
0a9f97f
@shaka-bot shaka-bot mentioned this pull request Apr 8, 2024
Merged
joeyparrish pushed a commit that referenced this pull request May 7, 2024
@avelad @joeyparrish
fix(DASH): Set delay to 0 for LL streams (#6406)
9c49645
@shaka-bot shaka-bot mentioned this pull request May 7, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 4, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avelad @shaka-bot @theodab