Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make getPlayheadTimeAsDate and getPresentationStartTimeAsDate available for VOD #6417

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: Make getPlayheadTimeAsDate and getPresentationStartTimeAsDate available for VOD #6417

merged 1 commit into from
Apr 10, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 8, 2024

Closes #2959

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Apr 8, 2024
@avelad avelad added this to the v5.0 milestone Apr 8, 2024
@avelad
Copy link
Collaborator Author

avelad commented Apr 8, 2024

Test stream: https://storage.googleapis.com/livestream-demo-output/ccl-webvtt-test/manifest-ts.m3u8

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 986071b into shaka-project:main Apr 10, 2024
20 checks passed
@shaka-bot shaka-bot mentioned this pull request Apr 10, 2024
Merged
@avelad avelad deleted the getPlayheadTimeAsDate-vod branch April 10, 2024 10:27
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 9, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

getPlayheadTimeAsDate and getPresentationStartTimeAsDate available for VOD
3 participants
@avelad @shaka-bot @theodab