Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ads): Fix ad pausing when using customPlayheadTracker #6444

Merged
merged 1 commit into from Apr 16, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 15, 2024

When using customPlayheadTracker the content of video could have been replaced by the advertisement (case of SmartTVs where only one video element is supported at a time), so we want to prevent actions from being taken on the advertisement.

@avelad avelad added type: bug Something isn't working correctly component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Apr 15, 2024
@avelad avelad added this to the v5.0 milestone Apr 15, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 75.00%

@avelad avelad merged commit 2d42933 into shaka-project:main Apr 16, 2024
19 of 21 checks passed
@avelad avelad deleted the pause-ad-smarttvs branch April 16, 2024 06:53
joeyparrish pushed a commit that referenced this pull request May 7, 2024
When using customPlayheadTracker the content of video could have been
replaced by the advertisement (case of SmartTVs where only one video
element is supported at a time), so we want to prevent actions from
being taken on the advertisement.
joeyparrish pushed a commit that referenced this pull request May 7, 2024
When using customPlayheadTracker the content of video could have been
replaced by the advertisement (case of SmartTVs where only one video
element is supported at a time), so we want to prevent actions from
being taken on the advertisement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants