Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix webOS 4 & 5 utility methods #6463

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

tykus160
Copy link
Contributor

webOS platforms don't contain OS version explicitly in user agent, instead they signal it via chrome version. This PR fixes webOS 4 & 5 methods and unifies all webOS check methods.

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Apr 22, 2024
@avelad avelad added this to the v4.8 milestone Apr 22, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 8c549f3 into shaka-project:main Apr 22, 2024
15 checks passed
@tykus160 tykus160 deleted the wt-webos-ua branch April 22, 2024 08:48
joeyparrish pushed a commit that referenced this pull request May 7, 2024
webOS platforms don't contain OS version explicitly in user agent,
instead they signal it via chrome version. This PR fixes webOS 4 & 5
methods and unifies all webOS check methods.
joeyparrish pushed a commit that referenced this pull request May 7, 2024
webOS platforms don't contain OS version explicitly in user agent,
instead they signal it via chrome version. This PR fixes webOS 4 & 5
methods and unifies all webOS check methods.
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 21, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants