Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix support of getAllThumbnails when using DASH multi-period #6464

Merged
merged 2 commits into from Apr 22, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 22, 2024

Fixes #6461

Tested by @tykus160

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround component: DASH The issue involves the MPEG DASH manifest format labels Apr 22, 2024
@avelad avelad added this to the v4.8 milestone Apr 22, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Apr 22, 2024

Incremental code coverage: 62.50%

Update implementation

Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
@avelad avelad merged commit 6905c74 into shaka-project:main Apr 22, 2024
14 of 15 checks passed
@avelad avelad deleted the getAllThumbnails-multi-period branch April 22, 2024 15:38
joeyparrish pushed a commit that referenced this pull request May 7, 2024
)

Fixes #6461

---------

Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
joeyparrish pushed a commit that referenced this pull request May 7, 2024
)

Fixes #6461

---------

Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
joeyparrish pushed a commit that referenced this pull request May 7, 2024
)

Fixes #6461

---------

Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
joeyparrish pushed a commit that referenced this pull request May 7, 2024
)

Fixes #6461

---------

Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for getAllThumbnails API with multi period manifest
4 participants