Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix reusing region elements in UITextDisplayer #6476

Merged

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 24, 2024

Fixes #6341

@avelad avelad added type: bug Something isn't working correctly component: TTML The issue involves TTML subtitles specifically component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Apr 24, 2024
@avelad avelad added this to the v4.8 milestone Apr 24, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 66.67%

@avelad avelad merged commit 4302a6b into shaka-project:main Apr 24, 2024
19 checks passed
@avelad avelad deleted the failed-execute-appendChild-on-Node branch April 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: captions/subtitles The issue involves captions or subtitles component: TTML The issue involves TTML subtitles specifically priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UITextDisplayer issue: Failed to execute 'appendChild' on 'Node': The new child element contains the parent
3 participants