fix: Do not assume 1080p Cast devices, some are 720p #6562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
alekzz
approved these changes
May 8, 2024
| maxResolution.height = 1080; | ||
| // Some hub devices can only do 720p. Default to that. | ||
| maxResolution.width = 1280; | ||
| maxResolution.height = 720; | ||
|
|
||
| try { | ||
| if (hasCanDisplayType && await cast.__platform__.canDisplayType( |
There was a problem hiding this comment.
nit; Up to your preference, just in case you missed it - you might check the presence of hasCanDisplayType just once.
There was a problem hiding this comment.
I tried it, but I think the extra layer of if outside the try/catch makes the method overall harder to read and follow. The runtime difference is negligible, so I'm leaving.
| maxResolution.width = 1920; | ||
| maxResolution.height = 1080; | ||
| // Some hub devices can only do 720p. Default to that. | ||
| maxResolution.width = 1280; |
There was a problem hiding this comment.
Just a heads up. The physical resolution of Google Nest Hub is 1024 x 600. But I guess it can play 720p.
There was a problem hiding this comment.
It can decode 720p, and with the typical encoding ladder people use, you'd hate to have them play 480p instead.
|
Incremental code coverage: 58.33% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.