fix(CEA): reset PTS on new init segment #6606
Conversation
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
Fixes #6605 Resets cache (including last used presentation timestamp) of CEA Decoder on every init segment append. Adds few debug logs to easify investigations in the future.
| shaka.log.debug('Passing new init segment to CEA parser'); | ||
| // Reset underlying decoder when new init segment arrives | ||
| // to clear stored pts values. | ||
| this.reset(); |
There was a problem hiding this comment.
Will this cause undesirable behavior on a bit-rate change?
There was a problem hiding this comment.
Can you be more specific? It seems to be the explicit intent of the author to reset CEA decoding when we switch bitrates (append init segment). What undesirable behavior are you seeing / anticipating?
There was a problem hiding this comment.
The issues addressed is "Closed Captions from main content appear in the end of midroll" which indicates to me a concern with period changes, not bitrate changes. I think this change might cause captions to disappear earlier than they should on a bitrate change.
There was a problem hiding this comment.
i think they need to distinguish period change from bitrate change.
There was a problem hiding this comment.
Yes, you are right. @caridley can you send a PR to fix it?
There was a problem hiding this comment.
I don't think I will have time to do that. Sorry
There was a problem hiding this comment.
I have a fix for it, #6671
Fixes #6605 Resets cache (including last used presentation timestamp) of CEA Decoder on every init segment append. Adds few debug logs to easify investigations in the future.
Fixes #6605
Resets cache (including last used presentation timestamp) of CEA Decoder on every init segment append.
Adds few debug logs to easify investigations in the future.