Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filters and additional network requests easier #667

Closed
joeyparrish opened this issue Jan 26, 2017 · 0 comments
Closed

Make filters and additional network requests easier #667

joeyparrish opened this issue Jan 26, 2017 · 0 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

While working on a tutorial for asynchronous request filters, I found that the tutorial code was more complicated than it should be. The main problems were:

  1. Converting between ArrayBuffer and string requires too much effort outside the library. An app/filter should be able to deal with request and response bodies either as ArrayBuffer or string.
  2. Making additional network requests from the application level required all request fields to be provided. The NetworkingEngine should fill in defaults when fields are missing.
@joeyparrish joeyparrish added the type: enhancement New feature or request label Jan 26, 2017
@joeyparrish joeyparrish added this to the v2.1.0 milestone Jan 26, 2017
@joeyparrish joeyparrish self-assigned this Jan 26, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants