Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useRelativeCueTimestamps option #726

Closed
joeyparrish opened this issue Mar 16, 2017 · 2 comments
Closed

Remove useRelativeCueTimestamps option #726

joeyparrish opened this issue Mar 16, 2017 · 2 comments
Labels
status: archived Archived and locked; will not be updated type: code health A code health issue
Milestone

Comments

@joeyparrish
Copy link
Member

In v2.0.1, we introduced the useRelativeCueTimestamps option to control the behavior of our WebVTT parser. We decided in #480 (comment) that we would remove this option in v2.1.0. All WebVTT timestamps in v2.1.0 will be relative to the segment time.

@joeyparrish joeyparrish added the type: code health A code health issue label Mar 16, 2017
@joeyparrish joeyparrish added this to the v2.1.0 milestone Mar 16, 2017
@TheModMaker
Copy link
Contributor

We also have a custom asset Tears of Steel (multiperiod with segmented subtitles and PTO) which uses Period-relative timestamps (IIRC). This was added to specifically test the old behavior and should be updated to match the new behavior. (I was the one who created this asset, so I can help)

@joeyparrish
Copy link
Member Author

That asset is still referenced by existing versions, so any updates should be made by forking that asset for v2.1.0 and leaving the existing one where it is.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: code health A code health issue
Projects
None yet
Development

No branches or pull requests

4 participants