Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose license expiration times #727

Closed
joeyparrish opened this issue Mar 17, 2017 · 1 comment
Closed

Expose license expiration times #727

joeyparrish opened this issue Mar 17, 2017 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

Shaka Player should expose license expiration times, both for playing content and for content stored offline.

For playing content, we already have this information in DrmEngine. It should be exposed through a method on Player. It might also be useful to fire an event from Player when the expiration time changes.

For offline content, we could get the expiration time by loading the stored sessions. Ideally, we would store this when the content is initially stored, rather than loading all stored sessions when the application asks for a content list.

For offline, we should start with a change to store the expiration time when we store the content. As persistent licenses are currently only supported by Chrome on ChromeOS, it is unlikely that there is a strong need to update existing stored content with expiration times. If the community requests an update path, we can add one later.

@joeyparrish joeyparrish added the type: enhancement New feature or request label Mar 17, 2017
@joeyparrish joeyparrish added this to the v2.1.0 milestone Mar 17, 2017
@joeyparrish
Copy link
Member Author

Adding this optimistically to the v2.1.0 milestone. If we finish HLS before we finish this, we'll bump this feature to the next release.

@TheModMaker TheModMaker self-assigned this Mar 17, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants