Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not error on invalid XLink. #788

Closed
theodab opened this issue May 8, 2017 · 3 comments
Closed

Add option to not error on invalid XLink. #788

theodab opened this issue May 8, 2017 · 3 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@theodab
Copy link
Collaborator

theodab commented May 8, 2017

Refactor the xlink parser so there's the option of not replacing the period on error, or if there's nothing loaded.
I.E. so there can be a default placeholder advertisement if no advertisements load.
The DASH IOP mentions default content for periods with xlink links, which suggests this is the intended behavior.

@theodab theodab added the type: enhancement New feature or request label May 8, 2017
@theodab theodab added this to the v2.2.0 milestone May 8, 2017
@theodab theodab self-assigned this May 23, 2017
@jide
Copy link

jide commented Aug 29, 2017

Hi,

According to changelog https://github.com/google/shaka-player/blob/master/CHANGELOG.md, a basic support for xlink has been implemented.

It references this issue, #587, but the mpd uri provided as an example there does not work, although it only uses xlink:actuate="onLoad".

Any idea why ?

@joeyparrish
Copy link
Member

@jide, the manifest in question (http://dash.edgesuite.net/fokus/adinsertion-samples/xlink/threeperiods.mpd) has two periods with audio & video, and one period with only video. So the error message (UNPLAYABLE_PERIOD) is accurate. We cannot switch between periods in which audio/video are missing. So if any one period has audio & video, all periods must have both audio & video for this to be playable in a continuous MediaSource presentation.

Here is a link to a working xlink demo in Shaka Player, using content with consistent content types across all three periods: https://shaka-player-demo.appspot.com/demo/#asset=//storage.googleapis.com/shaka-demo-assets/heliocentrism-xlink/heliocentrism.mpd;play

@jide
Copy link

jide commented Aug 29, 2017

@joeyparrish Oh, I see, not familiar with error messages yet. Awesome !

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants