Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing assertions during playback #954

Closed
joeyparrish opened this issue Jul 31, 2017 · 1 comment
Closed

Failing assertions during playback #954

joeyparrish opened this issue Jul 31, 2017 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

Using latest master branch, we are failing these assertions in player.js on Chrome Linux with the default test asset ("Angel One"):

  if (streams[ContentType.AUDIO] || streams[ContentType.VIDEO]) {
    var audio = streams[ContentType.AUDIO] || null;
    var video = streams[ContentType.VIDEO] || null;
    variant = this.findVariantByStreams_(period, audio, video);
    goog.asserts.assert(variant != null, 'Should not be null!');
  }
  var playerActive = this.activeStreamsByPeriod_[currentPeriodIndex] || {};
  for (var type in streamingActive) {
    var activeId = streamingActive[type].id;
    if (this.deferredSwitches_[type])
      activeId = this.deferredSwitches_[type].stream.id;
    goog.asserts.assert(activeId == playerActive[type],
                        'Inconsistent active stream');
  }

This is not happening in v2.1.5.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jul 31, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Jul 31, 2017
@joeyparrish joeyparrish self-assigned this Jul 31, 2017
@joeyparrish
Copy link
Member Author

This small issue turned out to require a large fix and much internal refactoring.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants