DL - Adding support for setting the callback URL with the OpenID Connect client. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sftwninja
approved these changes
Mar 13, 2017
maulin
reviewed
Mar 13, 2017
strategy.js
Outdated
| @@ -3,11 +3,11 @@ module.exports = function (passport, util) { | |||
|
|
|||
| function MockStrategy (options, verify) { | |||
| if (!verify) { throw new TypeError('MockStrategy requires a verify callback'); } | |||
| if (!options.callbackURL) { throw new TypeError('MockStrategy requires a callbackURL'); } | |||
| if (!options.callbackURL && !options.client.redirect_uris[0]) { throw new TypeError('MockStrategy requires a callbackURL'); } | |||
There was a problem hiding this comment.
I think this reads a little better to me. if !(options.callbackURL || options.client.redirect_uris[0])
nbd though
There was a problem hiding this comment.
Will change, and there is a test for the error thrown: https://github.com/shake-apps/passport-mocked/pull/14/files#diff-ecccc4504df76eb68f5239a9f48d7d4bL31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.