Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SF should check that a disk base is a valid image format #121

Open
mikalstill opened this issue Jul 3, 2020 · 2 comments
Open

SF should check that a disk base is a valid image format #121

mikalstill opened this issue Jul 3, 2020 · 2 comments
Labels
v0.3
Projects
Shaken Fist Self Hosted CI

Comments

@mikalstill
Copy link
Collaborator

Because you can't boot a 404 page, but it sure is confusing.
@mikalstill
Copy link
Collaborator Author

I think this one might be hard. qemu-img can tell us that a file is RAW (for example an HTML 404 page), but that is also a valid disk format. I am unsure how we test if it is bootable programmatically.

@mandoonandy
Copy link
Contributor

Maybe this is a naive approach?
Check for RAW images that are too small to be a realistic disk image, also check that it contains HTML tags (or maybe 'not found' text).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v0.3
Projects
Shaken Fist Self Hosted CI
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikalstill @mandoonandy