Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run filters on bad commit before blame/bisection #7

Closed
shalinmangar opened this issue Aug 28, 2018 · 3 comments
Closed

Run filters on bad commit before blame/bisection #7

shalinmangar opened this issue Aug 28, 2018 · 3 comments

Comments

@shalinmangar
Copy link
Owner

We use the jenkins data to demote tests to detention and each such demotion is to be bisected to find the offending commit. However, for bisection to work we must be able to reproduce the test failure (unless it is a new test, in which case blame is a quick git log). We should run each demoted test against the configured filters and run blame only if the filters fail for this test. If the test passes our filters then we should mark the test somehow and indicate in the report{.json,.html} and skip running blame.

@shalinmangar
Copy link
Owner Author

Commit 2b53db2 is part of this issue.

@shalinmangar
Copy link
Owner Author

Commit 5106b3d is also related to this issue.

@shalinmangar
Copy link
Owner Author

Now that #6 has been fixed, this issue can be closed. We use the reproducible flag and good sha recorded by changes made in this commit to run blame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant