Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couldn't use JsendExceptionFormatter trait in App\Exceptions\Handler with Laravel 7 #9

Closed
it-one-mm opened this issue Jun 25, 2020 · 1 comment

Comments

@it-one-mm
Copy link

it-one-mm commented Jun 25, 2020

Error:
Declaration of Shalvah\LaravelJsend\JsendExceptionFormatter::prepareJsonResponse($request, Exception $e)
should be compatible with Illuminate\Foundation\Exceptions\Handler::prepareJsonResponse($request, Throwable $e)

My Handler Code

<?php

namespace App\Exceptions;

use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
use Shalvah\LaravelJsend\JsendExceptionFormatter;
use Throwable;
use Illuminate\Database\Eloquent\ModelNotFoundException;

class Handler extends ExceptionHandler
{
    use JsendExceptionFormatter;
    /**
     * A list of the exception types that are not reported.
     *
     * @var array
     */
    protected $dontReport = [
        //
    ];

    /**
     * A list of the inputs that are never flashed for validation exceptions.
     *
     * @var array
     */
    protected $dontFlash = [
        'password',
        'password_confirmation',
    ];

    /**
     * Report or log an exception.
     *
     * @param \Throwable $exception
     * @return void
     *
     * @throws \Exception
     */
    public function report(Throwable $exception)
    {
        parent::report($exception);
    }

    /**
     * Render an exception into an HTTP response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Throwable  $exception
     * @return \Symfony\Component\HttpFoundation\Response
     *
     * @throws \Throwable
     */
    public function render($request, Throwable $exception)
    {

        if ($exception instanceof ModelNotFoundException) {
            return response()->json([
                'error' => 'Entry for '.str_replace('App\\', '', $exception->getModel()).' not found'], 404);
        }

        return parent::render($request, $exception);
    }
}
@it-one-mm it-one-mm changed the title Couldn't use JsendExceptionFormatter trait in App\Exceptions\Handler Couldn't use JsendExceptionFormatter trait in App\Exceptions\Handler with Laravel 7 Jun 25, 2020
@shalvah
Copy link
Owner

shalvah commented Jun 25, 2020

Tagged a new release to fix this (2.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants